Add experimental support for Thread Sanitizer #2076
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rjmccall, @gribozavr please, take a look! |
|
@AnnaZaks Library changes LGTM! |
| @@ -297,7 +297,7 @@ template <class EntryTy> class ConcurrentMap { | |||
|
|
|||
| // Try to set the edge to the new node. | |||
| if (std::atomic_compare_exchange_strong_explicit(edge, &node, newNode, | |||
| std::memory_order_release, | |||
| std::memory_order_acq_rel, | |||
There was a problem hiding this comment.
Okay, but I'm going to link to C++ DR 2445 in protest. :)
|
Otherwise, runtime/IRGen changes LGTM. |
|
Can we separate the "enable tsan" changes from the "fix stuff detected by tsan" changes? |
|
|
||
| // Currently, more than one sanitizer cannot be enabled at the same time. | ||
| if (pKind != SanitizerKind::None && pKind != kind) { | ||
| SmallVector<char, 128> pb; |
|
@gparker42 They are all separate commits, which you can view individually. |
|
@swift-ci Please test |
This patch threads the TSan option through the front end.
This bug was reported by TSan.
Make sure the memory synchronization ordering on success is strictly stronger than the memory ordering of failure. This addresses a race reported by TSan when having both Swift tests and the runtime TSanified.
This data race is benign and should not occur on the platforms we currently care about. However, do set the ordering appropriately when built with TSan to avoid reporting races from Swift code. The metadata lookup code relies on these orderings for synchronization.
It is safe to only reset the counter when the count is non-zero. We always initialize the count to zero. This race has been reported by TSan.
|
@swift-ci Please test |
|
Awesome! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thread the -sanitize=thread option through the front end and fix a bunch of races it reported.